src: fix build on older compilers (gcc 4.8) #252
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build broke on older compilers (such as gcc 4.8) after nodejs#246 landed. The issue is related to using default values for templates in the ::Stringiy definition. This commit makes minimal changes to fix the build while keeping functionality intact. A follow-up refactor of Stringify<JSError> is required.
Contributor
Author
cjihrig
approved these changes
Dec 16, 2018
joyeecheung
approved these changes
Dec 17, 2018
mmarchini
added a commit
that referenced
this pull request
Dec 19, 2018
Build broke on older compilers (such as gcc 4.8) after #246 landed. The issue is related to using default values for templates in the ::Stringiy definition. This commit makes minimal changes to fix the build while keeping functionality intact. A follow-up refactor of Stringify<JSError> is required. PR-URL: #252 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Contributor
Author
|
Landed in c17d0d1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build broke on older compilers (such as gcc 4.8) after
#246 landed. The issue is related
to using default values for templates in the ::Stringiy definition. This
commit makes minimal changes to fix the build while keeping
functionality intact. A follow-up refactor of Stringify is
required.